FAPI: Fix error handling in state machines #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In some sub state machines, which had no async function, the state was not reset to the initial state in error cases. * In some FAPI commands in the async part it was not checked whether the command is state is equal _FAPI_STATE_INIT. * In several FAPI commands the current state of the FAPI context was not reset to _FAPI_STATE_INIT in error cases. Thus it was possible that a sequence error did occur after a normal error case. Fixes: tpm2-software#2752 Signed-off-by: Juergen Repp <[email protected]>
JuergenReppSIT
force-pushed
the
fapi-fix-sub-state-machines
branch
from
0e8fb9f to
1eab909
Compare
JuergenReppSIT
changed the title
JuergenReppSIT
force-pushed
the
fapi-fix-sub-state-machines
branch
from
c8c787e to
1eab909
Compare
The FAPI command context now is cleared in the async function of every command. Signed-off-by: Juergen Repp <[email protected]>
AndreasFuchsTPM
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus it was possible that a sequence error did occur after a normal error case.
Fixes: #2752