notification: send notifications in blocks received on sync reset for… #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
… new allocated streams
bas-vk
force-pushed
the
basvk/missing_notifications
branch
from
fb3f795 to
4946a79
Compare
clemire
reviewed
Feb 7, 2025
| if justAllocated { | ||
| // send notifications for all events in all blocks | ||
| for _, event := range block.GetEvents() { | ||
| if parsedEvent, err := events.ParseEvent(event); err == nil { |
There was a problem hiding this comment.
@bas-vk, is there a bug here where memberships from the current block are applied before the events are sent instead of after?
There was a problem hiding this comment.
Ah Austin is clarifying, nevermind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… new allocated streams