Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ticker attachment #2235

Merged
merged 4 commits into from
Feb 8, 2025
Merged

add ticker attachment #2235

merged 4 commits into from
Feb 8, 2025

Conversation

erikolsson
Copy link
Contributor

@erikolsson erikolsson commented Feb 3, 2025 •
edited
Loading

I think string makes sense for chain id.
Chain ID Formatting: https://docs.portalhq.io/resources/chain-id-formatting

we could even name it caip_2_chain_id for clarity

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
river-sample-app ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2025 10:14am

@erikolsson erikolsson requested a review from ttillberg February 4, 2025 07:57
@erikolsson
Copy link
Contributor Author

update: using string instead of bytes to support Solana contracts as well.

@erikolsson erikolsson merged commit 00c2cf7 into main Feb 8, 2025
10 checks passed
@erikolsson erikolsson deleted the erik/add-ticker-attachment branch February 8, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttillberg ttillberg ttillberg approved these changes

@sergekh2 sergekh2 Awaiting requested review from sergekh2 sergekh2 is a code owner

@texuf texuf Awaiting requested review from texuf texuf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikolsson @ttillberg