Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SDK to paginate miniblocks #1790

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Updated SDK to paginate miniblocks #1790

merged 7 commits into from
Dec 11, 2024

Conversation

rbhnt
Copy link
Contributor

@rbhnt rbhnt commented Dec 11, 2024 •
edited
Loading

GetMiniblocks endpoint has a limit of max items that can be returned per request (#1764) - some sort of pagination. This PR updates the client SDK to properly handle the behaviour of the updated endpoint.

@rbhnt rbhnt self-assigned this Dec 11, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
river-sample-app ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 6:19pm

@rbhnt rbhnt requested a review from bas-vk as a code owner December 11, 2024 18:17
@rbhnt rbhnt requested a review from texuf December 11, 2024 18:18
@rbhnt rbhnt merged commit ecefe23 into main Dec 11, 2024
9 checks passed
@rbhnt rbhnt deleted the rbhnt/update-sdk-to-use-get-miniblocks-pagination branch December 11, 2024 22:45
texuf added a commit that referenced this pull request Dec 17, 2024
@texuf
Revert "Updated SDK to paginate miniblocks (#1790)"
cde7072 
This reverts commit ecefe23.
@texuf texuf mentioned this pull request Dec 17, 2024
Merged
texuf added a commit that referenced this pull request Dec 17, 2024
@texuf
Revert changes to paginate miniblocks (#1844)
accb4bd 
We're seeing the route return 0 for the response.fromInclusive when it
shouldn't be...

Revert "Updated SDK to paginate miniblocks (#1790)"

This reverts commit ecefe23.


Revert "Fixes for new getMiniblocks function (#1840)"

This reverts commit cd79d8d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texuf texuf texuf approved these changes

@sergekh2 sergekh2 Awaiting requested review from sergekh2 sergekh2 is a code owner

@erikolsson erikolsson Awaiting requested review from erikolsson erikolsson is a code owner

@bas-vk bas-vk Awaiting requested review from bas-vk

Assignees

@rbhnt rbhnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbhnt @texuf