fix(sse_handler_middleware): also stop handshakes when the server clo…

…ses the connection
toverux · May 31, 2017 · 06e0722 · 06e0722
1 parent df6c169
commit 06e0722
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/sse_handler_middleware.ts b/src/sse_handler_middleware.ts
@@ -34,11 +34,11 @@ export function sseHandler(options: Partial<ISseMiddlewareOptions> = {}): Handle
         res.write(': sse-start\n');
 
         //=> Regularly send keep-alive SSE comments, clear interval on socket close
-        const keepAliveTimer = setInterval(() => {
-            res.write(': sse-keep-alive\n');
-        }, keepAliveInterval);
+        const keepAliveTimer = setInterval(() => res.write(': sse-keep-alive\n'), keepAliveInterval);
 
+        //=> When the connection gets closed (close=client, finish=server), stop the handshake timer
         res.once('close', () => clearInterval(keepAliveTimer));
+        res.once('finish', () => clearInterval(keepAliveTimer));
 
         //=> Done
         next();