Skip to content

Commit

Permalink
chore(release): version 1.4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
toverux committed Nov 27, 2024
1 parent 3637566 commit d420ab9
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 48 deletions.
15 changes: 3 additions & 12 deletions HallOfFame/ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
This updates delays a bit the loading of a Hall of Fame background image.
**Fixes:**

Before, the mod attempted to load an image as soon as possible to display it instantly when the menu was shown.

However, on lower-end machines or with large mod playsets, this could cause more noticeable UI stuttering when loading mods.

Furthermore, this could also have played a role in the elusive crash that some players experience when opening the game.

This update waits for the main menu to be shown *and* waits 500ms more before doing anything.

**These changes are experimental, if they don't yield good results they might be reverted.**

If you used to experience the crash-at-load and still have it after this update, *please* contact me on Discord or in the Forum thread to report it.
- Fix a benign UI error for game update 1.1.12f1.
- Slight spacing fix for the Take photo with HoF button that was too small since the previous game update.
4 changes: 2 additions & 2 deletions HallOfFame/HallOfFame.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Version>1.4.1</Version>
<FileVersion>1.4.1</FileVersion>
<Version>1.4.2</Version>
<FileVersion>1.4.2</FileVersion>

<OutputType>Library</OutputType>
<!-- According to @Wayz and @tdw_village on Discord, C# 9 is the highest version supported by Burst. -->
Expand Down
15 changes: 5 additions & 10 deletions HallOfFame/LongDescription.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,13 @@ are encouraged to donate when the balance is in the red.

## Known issue: possible (but benign) crash when starting the game

There is a bug in cohtml engine (the UI layer of Cities: Skylines II) that can
cause random (generally rare) crashes **for some users** with some playsets.
There is a confirmed bug in cohtml engine (the UI layer of Cities: Skylines II)
that can cause random (but rare) crashes for *some* users with *some* playsets.

This happens only at game load and does not f* up your savegame or settings,
it’s just a bit annoying.
The issue only happens when the game loads, if it did load you’re good to go.

The symptom is a crash to desktop with no error message in Player.log, a split
second after the main menu appears.

We’re still trying to figure out what triggers it and how to work around that
problem, but in the meantime, if you experience this issue, you can either
disable the mod or just accept it (or help me debug this thing lol) :D
The issue was recently mitigated by loading the mod’s UI slightly later, if you
still encounter this problem, please contact me.

## Special Thanks

Expand Down
32 changes: 9 additions & 23 deletions HallOfFame/Properties/PublishConfiguration.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,18 +111,13 @@ are encouraged to donate when the balance is in the red.

## Known issue: possible (but benign) crash when starting the game

There is a bug in cohtml engine (the UI layer of Cities: Skylines II) that can
cause random (generally rare) crashes **for some users** with some playsets.
There is a confirmed bug in cohtml engine (the UI layer of Cities: Skylines II)
that can cause random (but rare) crashes for *some* users with *some* playsets.

This happens only at game load and does not f* up your savegame or settings,
it’s just a bit annoying.
The issue only happens when the game loads, if it did load you’re good to go.

The symptom is a crash to desktop with no error message in Player.log, a split
second after the main menu appears.

We’re still trying to figure out what triggers it and how to work around that
problem, but in the meantime, if you experience this issue, you can either
disable the mod or just accept it (or help me debug this thing lol) :D
The issue was recently mitigated by loading the mod’s UI slightly later, if you
still encounter this problem, please contact me.

## Special Thanks

Expand Down Expand Up @@ -154,23 +149,14 @@ disable the mod or just accept it (or help me debug this thing lol) :D
<Screenshot Value="Properties/Screenshot8.png" />
<Tag Value="Code Mod" />
<ForumLink Value="https://forum.paradoxplaza.com/forum/threads/hall-of-fame.1704820/" />
<ModVersion Value="1.4.1" />
<ModVersion Value="1.4.2" />
<GameVersion Value="1.1.*" />
<Dependency Id="74417" DisplayName="Unified Icon Library" />
<Dependency Id="75426" DisplayName="I18n EveryWhere" />
<ChangeLog>This updates delays a bit the loading of a Hall of Fame background image.

Before, the mod attempted to load an image as soon as possible to display it instantly when the menu was shown.

However, on lower-end machines or with large mod playsets, this could cause more noticeable UI stuttering when loading mods.

Furthermore, this could also have played a role in the elusive crash that some players experience when opening the game.

This update waits for the main menu to be shown *and* waits 500ms more before doing anything.

**These changes are experimental, if they don't yield good results they might be reverted.**
<ChangeLog>**Fixes:**

If you used to experience the crash-at-load and still have it after this update, *please* contact me on Discord or in the Forum thread to report it.</ChangeLog>
- Fix a benign UI error for game update 1.1.12f1.
- Slight spacing fix for the Take photo with HoF button that was too small since the previous game update.</ChangeLog>
<ExternalLink Type="discord" Url="https://discord.gg/HTav7ARPs2" />
<ExternalLink Type="github" Url="https://github.com/toverux/HallOfFame" />
<ExternalLink Type="crowdin" Url="https://crowdin.com/project/halloffame-cs2" />
Expand Down
2 changes: 1 addition & 1 deletion HallOfFame/UI/mod.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "HallOfFame",
"author": "Morgan Touverey Quilling",
"version": "1.4.1",
"version": "1.4.2",
"dependencies": []
}

0 comments on commit d420ab9

Please sign in to comment.