Skip to content

Commit

Permalink
fix(@toss/use-overylay): unnecessary code and docs (#345)
Browse files Browse the repository at this point in the history
* chore(@toss/use-overlay): fix null exception

* chore(@toss/use-overlay): delete any type

* chore(@toss/use-overlay): explicit naming

* docs(@toss/use-overlay): delete unnecessary docs

* chore: rollback null exception

* chore: rollback delete unnecessary docs

* chore: fix handler naming
  • Loading branch information
SEOKKAMONI authored Oct 9, 2023
1 parent 7f7a414 commit cbfb2eb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions packages/react/use-overlay/src/OverlayController.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @tossdocs-ignore */
import { Ref, useImperativeHandle, forwardRef, useEffect, useState, useCallback } from 'react';
import { forwardRef, Ref, useCallback, useEffect, useImperativeHandle, useState } from 'react';

import { CreateOverlayElement } from './types';

Expand All @@ -16,24 +16,24 @@ export const OverlayController = forwardRef(function OverlayController(
{ overlayElement: OverlayElement, onExit }: Props,
ref: Ref<OverlayControlRef>
) {
const [isOpen, setIsOpen] = useState(false);
const [isOpenOverlay, setIsOpenOverlay] = useState(false);

const handleClose = useCallback(() => setIsOpen(false), []);
const handleOverlayClose = useCallback(() => setIsOpenOverlay(false), []);

useImperativeHandle(
ref,
() => {
return { close: handleClose };
return { close: handleOverlayClose };
},
[handleClose]
[handleOverlayClose]
);

useEffect(() => {
// NOTE: requestAnimationFrame이 없으면 가끔 Open 애니메이션이 실행되지 않는다.
requestAnimationFrame(() => {
setIsOpen(true);
setIsOpenOverlay(true);
});
}, []);

return <OverlayElement isOpen={isOpen} close={handleClose} exit={onExit} />;
return <OverlayElement isOpen={isOpenOverlay} close={handleOverlayClose} exit={onExit} />;
});
2 changes: 1 addition & 1 deletion packages/react/use-overlay/src/tests/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export function renderWithContext<
return render<Q, C>(ui, {
...options,
wrapper: ({ children }) => {
const Wrapper = options.wrapper ?? (Fragment as any);
const Wrapper = options.wrapper ?? Fragment;

return (
<Wrapper>
Expand Down

0 comments on commit cbfb2eb

Please sign in to comment.