feat: drop support for Python3.8 #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1848 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 12879310652Details
💛 - Coveralls |
henadzit
reviewed
Jan 20, 2025
| meta.fields_map = fields_map | ||
| meta.fields_db_projection = fields_db_projection | ||
| meta._filters = filters | ||
| meta.fk_fields = fk_fields | ||
| meta.backward_fk_fields = set() |
There was a problem hiding this comment.
Why are backward_fk_fields, default_connection and other fields are removed from here?
There was a problem hiding this comment.
Because there are defined in MetaInfo.__init__:
tortoise-orm/tortoise/models.py
Line 240 in 71624e7
tortoise/models.py
Outdated
| class ModelMeta(type): | ||
| __slots__ = () | ||
| # Searching for Field attributes in the class hierarchy | ||
| def _search_for_field_attributes(base: Type, attrs: dict) -> None: |
There was a problem hiding this comment.
I think it should be a static method as parse_custom_pk and dispatch_fields, I don't see a reason why we would want to keep it as a function.
There was a problem hiding this comment.
Moved it into ModelMeta as a classmethod, because it's a recursion function that can not be set as staticmethod.
henadzit
approved these changes
Jan 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python3.8 already EOL: https://devguide.python.org/versions/
Motivation and Context
Changes:
typing.List/Tuple/Set/Dict-->list/tuple/set/dicttyping.Callable/Coroutine/Iterable/...-->collections.abc.Callable/Coroutine/Iterable/...functools.lru_cache(maxsize=None)-->functools.cachesuper(xxx, self)->super()tortoise.models.ModelMetato fix codacy issue (python -m mccabe --min 15 tortoise/models.py)How Has This Been Tested?
make ci
Checklist: