Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce duplicated code in tests #1846

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

waketzheng
Copy link
Contributor

Description

Just a simple refactor

Motivation and Context

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@waketzheng waketzheng requested a review from henadzit January 9, 2025 10:13
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #1846 will not alter performance

Comparing waketzheng:simple-refactor (06442cc) with develop (8b5ac14)

Summary

✅ 8 untouched benchmarks

@coveralls
Copy link

coveralls commented Jan 9, 2025

Pull Request Test Coverage Report for Build 12694844707

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.145%

Totals Coverage Status
Change from base Build 12617761088: 0.0%
Covered Lines: 6460
Relevant Lines: 7048

💛 - Coveralls

@waketzheng waketzheng requested a review from abondar January 12, 2025 10:10
@waketzheng waketzheng merged commit 7340e6e into tortoise:develop Jan 20, 2025
10 checks passed
@waketzheng waketzheng deleted the simple-refactor branch January 21, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants