-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone
and use_utc
parameters into RegisterTortoise
class.
#1649
Conversation
@Abeautifulsnow seems like tests are failing |
Ummm... It seems I know where the problem lies. My two test assertions timezones are both based on |
Yeah, you would need to somehow modify it, so it doesn't rely on what environment it is, as github action do not give any guarantees regarding their timezones |
The changes has been Done! @abondar |
It seems the issue is due to other test files, not my own. Could you please check it out? Thank you. |
Pull Request Test Coverage Report for Build 9559957832Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Description
A detailed description can be found here: #1632
Motivation and Context
There are no
timezone
andutc
configurations which can be applied toRegisterTortoise
class when usingdb_url
to initialize a sql connection. I've made them available inRegisterTortoise
, allowing users to conveniently specify these settings.How Has This Been Tested?
There are no side effects on other areas of the code. It just introduces two parameters within the
RegisterTortoise
. I have tested it within my project, and it works with these settings specified. #1632And can also be tested with:
I have also added test cases for the modified parts and passed the self-test.
Checklist: