Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(config): fix the parse of edge_path ENV var #482

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR fixes the parsing of the edge-path when set by env var.
It also refactors a bit how the edge binary path is created and add non regression tests.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner March 20, 2024 15:33
@Freyskeyd Freyskeyd requested review from dvdplm and atanmarko March 20, 2024 15:33
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.08%. Comparing base (642203c) to head (40b7e22).
Report is 2 commits behind head on main.

❗ Current head 40b7e22 differs from pull request most recent head 1574999. Consider uploading reports for the commit 1574999 to get more accurate results

Files Patch % Lines
crates/topos-node/src/lib.rs 80.00% 1 Missing ⚠️
crates/topos/src/components/node/commands/init.rs 0.00% 1 Missing ⚠️
crates/topos/src/components/node/commands/up.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   71.91%   72.08%   +0.16%     
==========================================
  Files         227      227              
  Lines       12745    12828      +83     
==========================================
+ Hits         9166     9247      +81     
- Misses       3579     3581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hadjiszs hadjiszs merged commit b2a1af0 into main Mar 20, 2024
19 checks passed
@hadjiszs hadjiszs deleted the fix/fixing-custom-path-for-edge branch March 20, 2024 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants