Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: fixing wrong use of IntCounterVec #442

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR fixes a wrong configuration for the IntCounterVec metrics on p2p layer.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner January 26, 2024 19:13
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (917eaf9) 66.13% compared to head (7bd22ff) 67.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   66.13%   67.94%   +1.80%     
==========================================
  Files         224      225       +1     
  Lines       13152    13170      +18     
==========================================
+ Hits         8698     8948     +250     
+ Misses       4454     4222     -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the fix/wrong-usage-metric-countervec branch from fc948c9 to 7bd22ff Compare January 27, 2024 19:53
@Freyskeyd Freyskeyd merged commit fe062a5 into main Jan 29, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the fix/wrong-usage-metric-countervec branch January 29, 2024 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants