Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

refactor: graphql types to differentiate inputs #435

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR prepares the work to add the position and expose more fields to GraphQL.
It updates the different input such as SourceStreamPosition to SourceStreamPositionInput.

Breaking changes

BREAKING CHANGE: This break the 0.0.10 GraphQL API definition due to the rename of some fields.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner January 22, 2024 13:31
@Freyskeyd Freyskeyd force-pushed the feature/tp-761/reorganization branch from 502c5f8 to 08615b1 Compare January 22, 2024 13:32
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (acedac7) 0.00% compared to head (89f24d3) 68.08%.

Files Patch % Lines
crates/topos-core/src/uci/subnet_id.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #435       +/-   ##
=========================================
+ Coverage      0   68.08%   +68.08%     
=========================================
  Files         0      224      +224     
  Lines         0    13129    +13129     
=========================================
+ Hits          0     8939     +8939     
- Misses        0     4190     +4190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BREAKING CHANGE: This break the 0.0.10 GraphQL API definition

Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the feature/tp-761/reorganization branch from 08615b1 to 89f24d3 Compare January 24, 2024 10:44
@Freyskeyd Freyskeyd merged commit 4b0ec9b into main Jan 25, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the feature/tp-761/reorganization branch January 25, 2024 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants