Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: fix logs for pending #432

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: fix logs for pending #432

merged 1 commit into from
Jan 19, 2024

Conversation

Freyskeyd
Copy link
Member

Description

Fixes a missmatch between log and error expectations.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd requested a review from a team as a code owner January 19, 2024 16:39
@Freyskeyd Freyskeyd requested review from dvdplm and gruberb January 19, 2024 16:39
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8fb4003) 66.95% compared to head (d9e7275) 67.04%.
Report is 2 commits behind head on main.

Files Patch % Lines
crates/topos-tce/src/app_context/network.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   66.95%   67.04%   +0.09%     
==========================================
  Files         220      220              
  Lines       12109    12110       +1     
==========================================
+ Hits         8107     8119      +12     
+ Misses       4002     3991      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gruberb gruberb merged commit 342b2c7 into main Jan 19, 2024
20 of 21 checks passed
@gruberb gruberb deleted the fix/logs-pending branch January 19, 2024 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants