Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: improve sequencer error handling and shutdown/restart sequence #428

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Jan 12, 2024

Description

Updated sequencer error handling of communication with subnet node and tce.

Fixes TP-828

Additions and Changes

  • Backoff timeouts are increased, for connection to subnet or tce node to 12 hours
  • In case of the failed certificate submit to the tce, or watch certificate channel failure, shutdown and restart sequencer
  • When initial sequencer backoff launch sequence fails, retry again (restart sequencer)

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Jan 12, 2024
@atanmarko atanmarko changed the title feat: improve sequencer error handling and restart sequencer feat: improve sequencer error handling and shutdown/restart sequence Jan 12, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (355b08a) 0.00% compared to head (2eb02ce) 67.79%.

Files Patch % Lines
crates/topos-sequencer/src/lib.rs 0.00% 63 Missing ⚠️
crates/topos-sequencer/src/app_context.rs 0.00% 26 Missing ⚠️
crates/topos-sequencer-subnet-client/src/lib.rs 0.00% 20 Missing ⚠️
crates/topos-sequencer-subnet-runtime/src/proxy.rs 0.00% 8 Missing ⚠️
crates/topos-tce-proxy/src/client.rs 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #428       +/-   ##
=========================================
+ Coverage      0   67.79%   +67.79%     
=========================================
  Files         0      224      +224     
  Lines         0    13127    +13127     
=========================================
+ Hits          0     8900     +8900     
- Misses        0     4227     +4227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko marked this pull request as ready for review January 22, 2024 17:43
@atanmarko atanmarko requested a review from a team as a code owner January 22, 2024 17:43
@atanmarko atanmarko merged commit ab8bb9e into main Jan 23, 2024
21 checks passed
@atanmarko atanmarko deleted the feat/TP-828 branch January 23, 2024 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants