Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: remove the register commands macro #426

Merged
merged 2 commits into from
Jan 4, 2024
Merged

feat: remove the register commands macro #426

merged 2 commits into from
Jan 4, 2024

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Jan 4, 2024

Description

Remove not needed RegisterCommands macro, which was used for GetAllSubnets in the Gatekeeper client. This is not needed anymore.

Fixes TP-562

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@gruberb gruberb requested a review from a team as a code owner January 4, 2024 15:08
@gruberb gruberb requested review from Freyskeyd and atanmarko January 4, 2024 15:08
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

@gruberb gruberb changed the title Feat/tp 562 feat: Remove the register commands macro Jan 4, 2024
@gruberb gruberb changed the title feat: Remove the register commands macro feat: remove the register commands macro Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e72999) 65.71% compared to head (8c4de78) 67.37%.
Report is 5 commits behind head on main.

Files Patch % Lines
crates/topos-tce/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   65.71%   67.37%   +1.65%     
==========================================
  Files         223      219       -4     
  Lines       11921    11882      -39     
==========================================
+ Hits         7834     8005     +171     
+ Misses       4087     3877     -210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruberb
Copy link
Contributor Author

gruberb commented Jan 4, 2024

Seems like we don't use GetAllSubnets anymore. Or am I wrong @Freyskeyd?

Copy link
Member

@Freyskeyd Freyskeyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gatekeeper is useless for now as we do not handle the validators in it. We'll need to re-add some part when working on it later.

@gruberb gruberb merged commit 985d0be into main Jan 4, 2024
29 of 32 checks passed
@gruberb gruberb deleted the feat/TP-562 branch January 4, 2024 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants