Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: updating double echo for devnet #416

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Freyskeyd
Copy link
Member

Description

Updating double echo for devnet debug

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner December 19, 2023 16:23
@Freyskeyd Freyskeyd requested review from hadjiszs and atanmarko and removed request for a team December 19, 2023 16:23
@Freyskeyd Freyskeyd changed the title feat: update tce config addresses chore: updating double echo for devnet Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (22a3745) 67.01% compared to head (65fa7f1) 69.24%.
Report is 4 commits behind head on main.

❗ Current head 65fa7f1 differs from pull request most recent head 881c2bf. Consider uploading reports for the commit 881c2bf to get more accurate results

Files Patch % Lines
crates/topos-tce-broadcast/src/double_echo/mod.rs 47.16% 28 Missing ⚠️
crates/topos-tce/src/app_context/network.rs 10.52% 17 Missing ⚠️
crates/topos-tce-broadcast/src/task_manager/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   67.01%   69.24%   +2.22%     
==========================================
  Files         220      219       -1     
  Lines       11908    11967      +59     
==========================================
+ Hits         7980     8286     +306     
+ Misses       3928     3681     -247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is some sort of temporary change to make debugging easier? If so it would be good to state that in the PR description.

@Freyskeyd Freyskeyd marked this pull request as draft December 20, 2023 12:49
@Freyskeyd Freyskeyd added this to the Soft-fork investigation milestone Dec 20, 2023
@Freyskeyd Freyskeyd force-pushed the feature/updating-p2p-config-file branch 6 times, most recently from 3c45f4c to e19650d Compare December 21, 2023 20:16
@Freyskeyd Freyskeyd force-pushed the chore/updating-double-echo-devnet branch from f6bd84d to 0b74b85 Compare December 21, 2023 20:17
@Freyskeyd Freyskeyd force-pushed the feature/updating-p2p-config-file branch from e19650d to cc9165a Compare December 22, 2023 09:25
@Freyskeyd Freyskeyd force-pushed the chore/updating-double-echo-devnet branch from 0b74b85 to 4456e99 Compare December 22, 2023 09:26
@Freyskeyd Freyskeyd marked this pull request as ready for review January 8, 2024 15:34
Base automatically changed from feature/updating-p2p-config-file to main January 8, 2024 20:07
@Freyskeyd Freyskeyd force-pushed the chore/updating-double-echo-devnet branch 3 times, most recently from 65fa7f1 to a0b98cb Compare January 9, 2024 08:53
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the chore/updating-double-echo-devnet branch from a0b98cb to 881c2bf Compare January 9, 2024 12:43
@Freyskeyd Freyskeyd merged commit 1e91086 into main Jan 9, 2024
19 checks passed
@Freyskeyd Freyskeyd deleted the chore/updating-double-echo-devnet branch January 9, 2024 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants