This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83478e0
to
cff0aa8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 66.97% 69.39% +2.41%
==========================================
Files 223 223
Lines 11923 11970 +47
==========================================
+ Hits 7986 8307 +321
+ Misses 3937 3663 -274 ☔ View full report in Codecov by Sentry. |
e8c9c87
to
70acf64
Compare
cff0aa8
to
b5202d1
Compare
Use a dedicated config struct for P2P stuff, expose two types of addresses and support defining multiple addresses per category. BREAKING CHANGE: The `libp2p_api_addr` is replaced by `listen_addresses` and `advertised_addresses` Signed-off-by: Simon Paitrault <[email protected]>
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
atanmarko
reviewed
Dec 21, 2023
b5202d1
to
1fc7346
Compare
4 tasks
Signed-off-by: Simon Paitrault <[email protected]>
3c45f4c
to
e19650d
Compare
hadjiszs
reviewed
Dec 21, 2023
Signed-off-by: Simon Paitrault <[email protected]>
e19650d
to
cc9165a
Compare
atanmarko
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the configuration of the
TCE
by removinglibp2p_api_addr
which was originally binding and exposing the address of the node. Now the configuration uses a dedicatedP2PConfig
to hold specific p2p config, the two first parameters are:listen_addresses
which accept a list ofmultiaddr
that the node will listen on for new incoming connectionpublic_addresses
which define the list of addresses that are publicly exposed by the node and will be advertised by theidentify
protocol.Future breaking change
libp2p_api_addr
is deprecatedExample
example of a new configuration:
PR Checklist: