This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
chore: refactor push certificate tests and cleanup regtest #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanmarko
force-pushed
the
feat/TP-808
branch
from
1bfe2c5 to
29f5559
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 66.97% 67.58% +0.60%
==========================================
Files 223 220 -3
Lines 11923 11823 -100
==========================================
+ Hits 7986 7990 +4
+ Misses 3937 3833 -104 ☔ View full report in Codecov by Sentry. |
atanmarko
requested review from
dvdplm and
Freyskeyd
and removed request for
a team
dvdplm
reviewed
Dec 12, 2023
atanmarko
force-pushed
the
chore/TP-807
branch
from
992b287 to
0426798
Compare
atanmarko
force-pushed
the
feat/TP-808
branch
from
fb958e2 to
489752b
Compare
hadjiszs
suggested changes
Dec 21, 2023
atanmarko
force-pushed
the
feat/TP-808
branch
from
5728d2e to
979e653
Compare
hadjiszs
reviewed
Dec 22, 2023
hadjiszs
approved these changes
Dec 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
regtest push-certificatesubcommand. Run standalone Rust test for related functionality.Fixes TP-808
PR Checklist: