This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
chore: run tce only if there is tce config #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 62.60% 62.61% +0.01%
==========================================
Files 218 218
Lines 11874 11878 +4
==========================================
+ Hits 7434 7438 +4
Misses 4440 4440 ☔ View full report in Codecov by Sentry. |
gruberb
suggested changes
Nov 20, 2023
| genesis, | ||
| (shutdown_token.clone(), shutdown_sender.clone()), | ||
| )); | ||
| if let Some(tce_config) = config.tce { |
There was a problem hiding this comment.
We can remove the unwrap and fail more gracefully, but we still need to fail.
|
Cancelled per discussion |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check of existence of tce component configuration before running tce process.
PR Checklist: