Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: change error to debug #378

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix: change error to debug #378

merged 2 commits into from
Nov 20, 2023

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Nov 20, 2023

Description

When a double echo message (READY | ECHO) is received from a non-validator (a node which is not part of the validator list), it's technically not an error. It's expected behaviour. So we change it to debug instead of error so we don't overcrowd our logs.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@gruberb gruberb requested a review from a team as a code owner November 20, 2023 12:17
@gruberb gruberb merged commit 7aea72c into main Nov 20, 2023
14 of 15 checks passed
@gruberb gruberb deleted the fix/change-double-echo-log-level branch November 20, 2023 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants