Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

test: adding certificate precedence ordering #375

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

Freyskeyd
Copy link
Member

Description

This PR adds tests regarding the precedence management and how it behaves for the API.

The context is to test which certificate is returned when call the get_latest_pending_certificate method when the storage contains one or more certificate in the precedence_pool.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner November 20, 2023 08:42
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38cc514) 62.61% compared to head (215aa1f) 62.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   62.61%   62.64%   +0.02%     
==========================================
  Files         218      219       +1     
  Lines       11876    11880       +4     
==========================================
+ Hits         7436     7442       +6     
+ Misses       4440     4438       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the test/test-precedence-ordering branch from 5b41a55 to 215aa1f Compare November 20, 2023 13:59
@dvdplm dvdplm merged commit fe7d95e into main Nov 20, 2023
@dvdplm dvdplm deleted the test/test-precedence-ordering branch November 20, 2023 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants