fix: fixing review comments

Signed-off-by: Simon Paitrault <[email protected]>

crates/topos-tce-storage/src/tests/checkpoints.rs

@@ -54,7 +54,7 @@ async fn get_checkpoint_diff_with_no_input(store: Arc<ValidatorStore>) {
     }
 
     let checkpoint = store
-        .get_checkpoint_diff(vec![])
+        .get_checkpoint_diff(&[])
         .unwrap()
         .into_iter()
         .map(|(subnet, proofs)| {
@@ -97,7 +97,7 @@ async fn get_checkpoint_diff_with_input(store: Arc<ValidatorStore>) {
     }
 
     let checkpoint = store
-        .get_checkpoint_diff(vec![checkpoint])
+        .get_checkpoint_diff(&[checkpoint])
         .unwrap()
         .into_iter()
         .map(|(subnet, proofs)| {

crates/topos-tce-storage/src/validator/mod.rs

@@ -29,7 +29,7 @@ use topos_core::{
     },
     uci::{Certificate, CertificateId, SubnetId, INITIAL_CERTIFICATE_ID},
 };
-use tracing::{debug, info, instrument};
+use tracing::{debug, error, info, instrument};
 
 use crate::{
     errors::{InternalStorageError, StorageError},
@@ -336,14 +336,17 @@ impl ValidatorStore {
 
     pub fn get_checkpoint_diff(
         &self,
-        from: Vec<ProofOfDelivery>,
+        from: &[ProofOfDelivery],
     ) -> Result<HashMap<SubnetId, Vec<ProofOfDelivery>>, StorageError> {
         // Parse the from in order to extract the different position per subnets
-        let mut from_positions: HashMap<SubnetId, Vec<ProofOfDelivery>> = from
-            .into_iter()
-            .map(|v| (v.delivery_position.subnet_id, vec![v]))
+        let from_positions: HashMap<SubnetId, &ProofOfDelivery> = from
+            .iter()
+            .map(|v| (v.delivery_position.subnet_id, v))
             .collect();
 
+        let mut output: HashMap<SubnetId, Vec<ProofOfDelivery>> =
+            from_positions.iter().map(|(s, _)| (*s, vec![])).collect();
+
         // Request the local head checkpoint
         let subnets: HashMap<SubnetId, Position> = self
             .fullnode_store
@@ -356,9 +359,7 @@ impl ValidatorStore {
         // For every local known subnets we want to iterate and check if there
         // is a delta between the from_position and our head position.
         for (subnet, local_position) in subnets {
-            let entry = from_positions.entry(subnet).or_default();
-
-            let certs: Vec<_> = if let Some(position) = entry.pop() {
+            let certs: Vec<_> = if let Some(position) = from_positions.get(&subnet) {
                 if local_position <= position.delivery_position.position {
                     continue;
                 }
@@ -393,10 +394,17 @@ impl ValidatorStore {
                 subnet,
                 proofs.len()
             );
-            entry.extend_from_slice(&proofs[..]);
+
+            if let Some(old_value) = output.insert(subnet, proofs) {
+                error!(
+                    "Certificate Sync: This should not happen, we are overwriting a value during \
+                     sync of {subnet}. Overwriting {}",
+                    old_value.len()
+                );
+            }
         }
 
-        Ok(from_positions)
+        Ok(output)
     }
 
     #[cfg(test)]

crates/topos-tce-synchronizer/src/checkpoints_collector/mod.rs

@@ -193,7 +193,10 @@ impl CheckpointSynchronizer {
             let len = proofs.len();
             let unverified_certs = self.store.insert_unverified_proofs(proofs)?;
 
-            debug!("Persist {} unverified proofs for {}", len, subnet);
+            debug!(
+                "Persist {} unverified proof of delivery for {}",
+                len, subnet
+            );
             certs.extend(&unverified_certs[..]);
         }
 

crates/topos-tce-synchronizer/src/lib.rs

@@ -166,7 +166,7 @@ impl GrpcSynchronizerService for SynchronizerService {
 
         debug!("Request {} contains {} proof_of_delivery", id, res.len());
         trace!("Request {} contains {:?}", id, res);
-        let diff = match self.validator_store.get_checkpoint_diff(res) {
+        let diff = match self.validator_store.get_checkpoint_diff(&res) {
             Ok(diff) => {
                 debug!(
                     "Fetched checkpoint diff from storage for request {}, got {:?}",