Fix BaseSumGenerator and BaseSplitGenerator Ids (0xPolygonZero#1494)

* fix: different ids for generators with different bases required for correct serialisation Signed-off-by: electron-team <[email protected]> * fixing wasm32 build issue Signed-off-by: electron-team <[email protected]> * fix fmt issue Signed-off-by: electron-team <[email protected]> --------- Signed-off-by: electron-team <[email protected]>
topos-protocol · Feb 1, 2024 · 1dc22b7 · 1dc22b7
1 parent f76245e
commit 1dc22b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/plonky2/src/gadgets/split_base.rs b/plonky2/src/gadgets/split_base.rs
@@ -1,6 +1,6 @@
-use alloc::string::{String, ToString};
-use alloc::vec;
+use alloc::string::String;
 use alloc::vec::Vec;
+use alloc::{format, vec};
 use core::borrow::Borrow;
 
 use itertools::Itertools;
@@ -91,7 +91,7 @@ impl<F: RichField + Extendable<D>, const B: usize, const D: usize> SimpleGenerat
     for BaseSumGenerator<B>
 {
     fn id(&self) -> String {
-        "BaseSumGenerator".to_string()
+        format!("BaseSumGenerator + Base: {B}")
     }
 
     fn dependencies(&self) -> Vec<Target> {

diff --git a/plonky2/src/gates/base_sum.rs b/plonky2/src/gates/base_sum.rs
@@ -1,4 +1,4 @@
-use alloc::string::{String, ToString};
+use alloc::string::String;
 use alloc::vec::Vec;
 use alloc::{format, vec};
 use core::ops::Range;
@@ -179,7 +179,7 @@ impl<F: RichField + Extendable<D>, const B: usize, const D: usize> SimpleGenerat
     for BaseSplitGenerator<B>
 {
     fn id(&self) -> String {
-        "BaseSplitGenerator".to_string()
+        format!("BaseSplitGenerator + Base: {B}")
     }
 
     fn dependencies(&self) -> Vec<Target> {