fix(nats): drain connections upon error #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
force-pushed
the
fix/drain-nats-conn
branch
3 times, most recently
from
5f65c0a to
f21f902
Compare
When failing to connect, drain connection rather than closing directly. This is safer than calling close and will wait for connections before closing, gracefully handling ongoing reconnects and avoid leaking goroutines in test
hspedro
force-pushed
the
fix/drain-nats-conn
branch
from
f21f902 to
1c2f000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When failing to connect, drain connection rather than closing directly. This is safer than calling close and will wait for connections before closing, gracefully handling ongoing reconnects and avoid leaking goroutines in test