feat(nats): add compression config (#432) #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NATS client and server, if the connection uses websocket we can enable compression by passing the Compression config - it needs to be enbaled on both client and server conn setup. Thus creating a new config to enbale on both sides - if not websocket, this config has no effect
Pull Request Test Coverage Report for Build 12774451974Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NATS client and server, if the connection uses websocket we can enable compression by passing the Compression config - it needs to be enbaled on both client and server conn setup. Thus creating a new config to enbale on both sides - if not websocket, this config has no effect
Porting changes from v2 to main v3: #432