Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hl): use default hl groups #28

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Conversation

disrupted
Copy link
Contributor

I've changed the default highlight groups to default ones so that every colorscheme is supported out of the box.

@topaxi
Copy link
Owner

topaxi commented Feb 20, 2025

Thank you!

Just a quick question, do you know how these are different and why? Are these new?
Mostly wondering, I didn't know about these, and they do look different in my theme.

Happy to merge, just quickly wanted to know the actual difference :)

@topaxi
Copy link
Owner

topaxi commented Feb 20, 2025

Ah I assume the normal diagnostics are not the virtual text ones but ones shown in other contexts. I think this definitely makes sense, as in our case these are normal text.

@topaxi topaxi enabled auto-merge (squash) February 20, 2025 17:25
@disrupted
Copy link
Contributor Author

disrupted commented Feb 21, 2025

thanks for the feedback. tbh I just couldn't find any official documentation of the LspDiagnosticsVirtualTextError hl groups in Neovim :help. Perhaps these predate vim.diagnostic?

It looks like you were ready to merge this but it didn't go through. PR might need approval first?

edit: forgot about the readme. updated now

auto-merge was automatically disabled February 21, 2025 17:34

Head branch was pushed to by a user without write access

@topaxi topaxi enabled auto-merge (squash) February 22, 2025 04:56
@topaxi topaxi merged commit 82f382c into topaxi:main Feb 22, 2025
3 checks passed
@topaxi
Copy link
Owner

topaxi commented Feb 22, 2025

Thanks for the update and contribution! <3

@disrupted disrupted deleted the fix/hl-diagnostic branch February 22, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants