Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print non-message to STDERR to avoid confusing emacs. #223

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

ikirill
Copy link
Contributor

@ikirill ikirill commented Apr 21, 2017

This isn't a real issue at all, just a nitpick, but I'm using STDOUT to communicate with a lint process, and printing non-json messages that aren't real lint messages makes the communication a little messier to parse—the output is no longer even valid json.

@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Coverage decreased (-0.7%) to 90.061% when pulling ecbb29a on ikirill:fix-println-stderr into 7f311ed on tonyhffong:master.

@TotalVerb
Copy link
Collaborator

LGTM. I think there are other places where we're printing to STDOUT too, but should be printing to STDERR, as noted here, but that can be fixed later. Tell me if you'd like a new tag — otherwise I'll hold off until after n-pass linting is done, as the current master temporarily has a lot more false positives than the latest release.

@TotalVerb TotalVerb merged commit f629ae0 into tonyhffong:master Apr 23, 2017
@TotalVerb
Copy link
Collaborator

Since we'll need #224 anyway, I've decided to just make a backport 0.5.1 release, and we may as well include this fix.

@ikirill ikirill deleted the fix-println-stderr branch April 30, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants