Enable ContinuousIntegrationBuild

ContinuousIntegrationBuild seems defunct for webforms although reported MSBuild version is 17.4.1.60106 Centralize version.txt
toniarnold · Jan 26, 2023 · 92e077c · 92e077c
1 parent 2e4d268
commit 92e077c
Show file tree

Hide file tree

Showing 18 changed files with 81 additions and 32 deletions.
diff --git a/.github/workflows/libs-build-release.yml b/.github/workflows/libs-build-release.yml
@@ -11,7 +11,5 @@ jobs:
   release:
     needs: [build-core, build-webforms]
     uses: ./.github/workflows/libs-release.yml
-    with:
-      version: v0.2.1
     secrets:
       nuget_api_key: ${{ secrets.NUGET_API }}
diff --git a/.github/workflows/libs-release.yml b/.github/workflows/libs-release.yml
@@ -2,11 +2,6 @@ name: Release Libraries
 
 on:
   workflow_call:
-    inputs:
-      version:
-        description: 'version tag name for the GitHub release'
-        required: true
-        type: string
     secrets:
       nuget_api_key:
         description: 'nuget.org API key'
@@ -43,10 +38,15 @@ jobs:
         nuget-api-key: ${{ secrets.nuget_api_key }}
     - name: Publish NuGet packages to nuget.org
       run: nuget push -Source https://api.nuget.org/v3/index.json '${{ github.workspace }}\packages\*.nupkg' -SkipDuplicate
-    - name: Create GitHub release ${{ inputs.version }}
+    - name: Get version.txt
+      shell: pwsh
+      run: |
+        $version = Get-Content ${{ github.workspace }}/nuget-info/version.txt
+        echo "version=$version" >> $Env:GITHUB_ENV
+    - name: Create GitHub release "v${{ env.version }}"
       uses: ncipollo/release-action@v1
       with:
         commit: master
-        tag: ${{ inputs.version }}
+        tag: "v${{ env.version }}"
         artifacts: "${{ github.workspace }}/packages/*.nupkg"
-        bodyFile: "${{ github.workspace }}/.github/workflows/release.md"
+        bodyFile: "${{ github.workspace }}/nuget-info/release-notes.txt"
diff --git a/.github/workflows/sandbox.yml b/.github/workflows/sandbox.yml
@@ -8,13 +8,7 @@ jobs:
   try:
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v3
-      with:
-        fetch-depth: 0
-    - name: Get version.txt
-      shell: pwsh
-      run: |
-        $version = Get-Content ${{ github.workspace }}/nuget-info/version.txt
-        echo "version=$version" >> $GITHUB_ENV
-    - name: Use version.txt
-      run: echo ">${{ env.version }}<"
+    - name: Add msbuild to PATH
+      uses: microsoft/[email protected]
+    - name: view version
+      run: msbuild --version
diff --git a/nuget-info/release-notes.txt b/nuget-info/release-notes.txt
@@ -1,17 +1,17 @@
-* Add Source Link to all NuGet packages
-
-* Fix race condition in the PersistentMainFactory due to the static cache 
+* Fix issue #5 race condition in the PersistentMainFactory due to the static cache 
   by setting up an identifying Request Correlation Guid in _Host.cshtml according to
   https://learn.microsoft.com/en-us/aspnet/core/blazor/security/server/additional-scenarios?view=aspnetcore-6.0#pass-tokens-to-a-blazor-server-app
 
 * Deprecate the 'Component' accessor in favor of 'Cut' as in
   https://learn.microsoft.com/en-us/aspnet/core/blazor/test
 
-* Set Selenium RequestTimeout default to 1 if not configured
+* Set Selenium RequestTimeout default to 1 sec if not configured
 
-* Blazor Test Navigate() and Refresh() as in Click() with numeric expectRenders
+* Blazor synchronization in Navigate() and Refresh() with the same argumenrs as Click() with numeric expectRenders
   instead of bool expectRender (breaking change)
 
-* Support the ?clear=true GET argument to clear browser storage also for Blazor
+* Support the ?clear=true GET argument to clear browser storage also in Blazor
+
+* Internet Explorer has been forcibly disabled by Microsoft, thus remove it from old tests.
 
-* Internet Explorer has been forcibly disabled by Microsoft, thus removed it from old tests.
+* Add Source Link to the NuGet packages
diff --git a/src/apicaller.core/apicaller.core.nuget.csproj b/src/apicaller.core/apicaller.core.nuget.csproj
@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)/../../nuget-info/version.txt"))" />
+    <PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText('$(MSBuildProjectDirectory)/../../nuget-info/version.txt'))" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/apiservice.core/apiservice.core.nuget.csproj b/src/apiservice.core/apiservice.core.nuget.csproj
@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)/../../nuget-info/version.txt"))" />
+    <PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText('$(MSBuildProjectDirectory)/../../nuget-info/version.txt'))" />
   </ItemGroup>
 
   <!-- Don't require the SMC code generator Makefile project dependency when /p:noSmc=true -->

diff --git a/src/apitest.core/apitest.core.nuget.csproj b/src/apitest.core/apitest.core.nuget.csproj
@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)/../../nuget-info/version.txt"))" />
+    <PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText('$(MSBuildProjectDirectory)/../../nuget-info/version.txt'))" />
     <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.13" />
     <PackageReference Include="nunit" Version="3.13.3" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.3.1">

diff --git a/src/asplib.blazor/asplib.blazor.csproj b/src/asplib.blazor/asplib.blazor.csproj
@@ -30,6 +30,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <SupportedPlatform Include="browser" />
   </ItemGroup>

diff --git a/src/asplib.core/asplib.core.csproj b/src/asplib.core/asplib.core.csproj
@@ -29,6 +29,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.13" />
     <PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.13" />

diff --git a/src/asplib.webforms/asplib.webforms.csproj b/src/asplib.webforms/asplib.webforms.csproj
@@ -39,6 +39,9 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>
     <DebugType>full</DebugType>

diff --git a/src/asplib.websharper/asplib.websharper.csproj b/src/asplib.websharper/asplib.websharper.csproj
@@ -29,6 +29,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="FSharp.Core" Version="6.0.7" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">

diff --git a/src/asplib/asplib.csproj b/src/asplib/asplib.csproj
@@ -16,6 +16,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
       <PrivateAssets>all</PrivateAssets>

diff --git a/src/iselenium.blazor/iselenium.blazor.csproj b/src/iselenium.blazor/iselenium.blazor.csproj
@@ -29,6 +29,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <SupportedPlatform Include="browser" />
   </ItemGroup>

diff --git a/src/iselenium.core/iselenium.core.csproj b/src/iselenium.core/iselenium.core.csproj
@@ -29,6 +29,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
       <PrivateAssets>all</PrivateAssets>

diff --git a/src/iselenium.webforms/iselenium.webforms.csproj b/src/iselenium.webforms/iselenium.webforms.csproj
@@ -40,6 +40,9 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>
     <DebugType>full</DebugType>

diff --git a/src/iselenium.websharper/iselenium.websharper.csproj b/src/iselenium.websharper/iselenium.websharper.csproj
@@ -28,6 +28,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
       <PrivateAssets>all</PrivateAssets>

diff --git a/src/iselenium/iselenium.csproj b/src/iselenium/iselenium.csproj
@@ -16,6 +16,10 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
       <PrivateAssets>all</PrivateAssets>

diff --git a/src/smc/smc.csproj b/src/smc/smc.csproj
@@ -10,6 +10,25 @@
 
   <PropertyGroup>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
-  </PropertyGroup>  
-
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- Source Link -->
+    <PublishRepositoryUrl>true</PublishRepositoryUrl>
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
+
 </Project>