Remove json parsing #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a couple problems: 1. Poison was pretty out of date (so trying to use the lib caused version conflicts with the version we were already using in our app) 2. Our draftjs content wasn't stored as a string, it was stored as a map. Removing json parsing will let the user parse it if they need to (in whatever way they want), and let those who don't need to use it out of the box.
Inline style ranges (right now only `BOLD` and `ITALIC`) and entity ranges (right now only `LINK`)
Add ranges to draft
Which can be hooked into in custom processors
`use` and `context`
Process `ul`s and `ol`s
Broke from 2726949
This made us able to do some unique things, like transforming content in our custom entities, that we were unable to do with our simpler approach.
Rewrite inline ranges as a tree
Handle headers four through six in process_block
Fixes UL and OL in outlook for
Because, yes, line length matters 😬
I hope this doesn't bite us in the butt, buttttt... there is a line length limit and this is really the best place IMO to put the newline because otherwise it could get converted to a space and be in a bad spot...
This reverts commit fd83069.
This reverts commit 346c877.
https://trello.com/c/DXA1F6ab Fixes a bug in Outlook that doesn’t respect an outer span’s styling on an inner a tag.
Add ability to control the order in which styles are applied to entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a couple problems:
Poison was pretty out of date (so trying to use the lib caused
version conflicts with the version we were already using in our app)
Our draftjs content wasn't stored as a string, it was stored as a
map. Removing json parsing will let the user parse it if they need
to (in whatever way they want), and let those who don't need to use
it out of the box.