Fix image links in documentation #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$reflectionObject->getFileName()` returns `/var/www/html/packages/project_core/Components/Organisms/Content/TextMedia` when the extension is symlinked by composer from packages to typo3conf/ext. This is a more dynamic approach to get the relative document directory. But I think it needs more work: * Currently `substr(Environment::getExtensionsPath(), strlen(Environment::getPublicPath()));` returns "/typo3conf/ext" like it's defined in the class "Environment". If TYPO3 would ever change the extension location we would be save, but for performance we could remove the string handling and just conactenate the strings like: `'/typo3conf/ext/' . $extDocPath`. As done in class "Environment". * I think if TYPO3 is installed in a subdirectory the image links wouldn't be correct. Actually I don't have this case myself but maybe someone else has.
|
I marked the PR as work in progress, as I think it's not ready to merge. But I want to make aware of the issue ;-) Edit: found the draft function of github. (I'm used to gitlab) |
schliesser
changed the title
|
@schliesser Great, thanks! Just let me know as soon as you consider the PR as finished. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$reflectionObject->getFileName()returns/var/www/html/packages/project_core/Components/Organisms/Content/TextMediawhen the extension is symlinked by composer from packages to typo3conf/ext.This is a more dynamic approach to get the relative document directory. But I think it needs more work:
substr(Environment::getExtensionsPath(), strlen(Environment::getPublicPath()));returns "/typo3conf/ext" like it's defined in the class "Environment". If TYPO3 would ever change the extension location we would be save, but for performance we could remove the string handling and just conactenate the strings like:'/typo3conf/ext/' . $extDocPath. As done in class "Environment".