-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EngineVersion #19
Conversation
P.S. since my team is going to use tolgee as translation platform, would you be interested in some code review and other improvement suggestions ._. |
Another suggestion is to remove this field whatsoever so that plugin won't be tied to any version Or set EngineVersion to lowest version available (i.e. 4.26.0), because if you apply my fix, then plugin won't be compatible with any versions lower then 5.3.0 |
Updated version to 4.26.0 |
Well, I've looked closely at FPluginManager::IsPluginCompatible and it actually will work only for same minor version, so my best suggestion is to simply remove EngineVersion from uplugin |
Hey @ViktorWii any review and suggestions are welcome. If you have any, I am happy to take a look and discuss them with you and your team. Regarding this change specifically, the I fully agree with you, this field should be optional and should be removed from all GitHub plugins. I've been advocating for it to the Marketplace submission, but unfortunately, as long as they require it to be present, having it here makes our lives easier when we submit updates to the Marketplace. |
Oh, now I see your reasoning... |
Unfortunately, yes. There is no CLI, no rest api endpoint, it's just a plain old upload zip. I hope it will change when Epic migrates to fab.com, but currently, it's fully manual.
It depends on the importance of the update. To save time, I usually just update the current engine version (in this case 5.3). If it's something important, I will duplicate the zip, change the engine version, and upload it to Google Drive/WeTransfer. To give you some more insights, currently, after we create a tag, a release will be created with the source code. Because this matches the current engine version (5.3) I can directly send the public GitHub artifact link to Epic. Of course, we could run a matrix action on GitHub Actions create 3 zips (one for each version) by injecting the |
@pasotee |
Couldn't be fixed due to Marketplace requirements |
Engine version string in Plugins/TolgeeSDK/Tolgee.uplugin could not be parsed ("5.3")
Sorry for bothering you, but here is another minor proposition
If you look at FEngineVersion::Parse, then you would notice that EngineVersion field supposed to have
Major.Minor.Patch
versionCurrently it's just a warning, but still thought that you might agree on this change
(Also double checked that in 4.26 FEngineVersion::Parse works exactly the same and expects
Major.Minor.Patch
format)