Add clippy::indexing_slicing to the list of ignored lints #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thanks.
It is usually a bug that clippy warns of code generated by external macros, and it also seems to be a bug that this lint is triggered for static slices and immediate indexes whose exact length is known at compile time, so I recommend you report the bug to clippy.
That said, it is very easy to work around this by ignoring it on our part, so adding a allow attribute is a reasonable action.
|
@taiki-e will do. Does anyone else needs approving this for it to be merged? The test failures seem completely unrelated. |
|
CI failure will be fixed in #119. I will merge this once the CI fix is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently using
valuableon a project that has most clippy lints enabled, and it is showing warnings because it uses direct array indexing to access the fields on the generated macro code. Unfortunately, there's no way to ignore it directly, as it gets "imported" to application code on macro expansion.This PR adds
clippy::indexing_slicingto the listing of ignored lints.