Skip to content

Commit

Permalink
chore: fix Rust 1.84.0 lints and errors (#3202)
Browse files Browse the repository at this point in the history
There was only a single case of the new `needless_as_bytes` lint which
was triggered and needed to be fixed.

There was also a "UI" test in `tracing-attributes` that needed to be
updated because the error text has changed (it gives more details of
course).
  • Loading branch information
hds committed Jan 24, 2025
1 parent 44b9493 commit 6240c95
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion tracing-attributes/tests/ui/async_instrument.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ error[E0277]: `(&str,)` doesn't implement `std::fmt::Display`
--> tests/ui/async_instrument.rs:14:1
|
14 | #[tracing::instrument]
| ^^^^^^^^^^^^^^^^^^^^^^ `(&str,)` cannot be formatted with the default formatter
| ^^^^^^^^^^^^^^^^^^^^^^
| |
| `(&str,)` cannot be formatted with the default formatter
| return type was inferred to be `(&str,)` here
|
= help: the trait `std::fmt::Display` is not implemented for `(&str,)`
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
Expand Down
2 changes: 1 addition & 1 deletion tracing-subscriber/src/fmt/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1186,7 +1186,7 @@ impl io::Write for WriteAdaptor<'_> {
.write_str(s)
.map_err(|e| io::Error::new(io::ErrorKind::Other, e))?;

Ok(s.as_bytes().len())
Ok(s.len())
}

fn flush(&mut self) -> io::Result<()> {
Expand Down

0 comments on commit 6240c95

Please sign in to comment.