Stabilize runtime::id::Id
#7125
Open
+52
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stabilizes the `runtime::id::Id`. `runtime::id::Id` uniquely identifies a runtime relative to the parent process' other currently running runtimes. It was introduced in July 2023 and has only received one modification since, where `impl From<NonZeroU32> for Id` was added in December 2023 in 3a4aef1 . ## `std::from::From` implementations This commit removes the runtime `Id`'s `From` implementations. Removing unnecessary publc APIs makes stabilizing the `Id` less risky. Instead, a crate private `Id::new` method has been introduced. This means that as of this commit, users can no longer safely construct an `Id`. Instead, they must get a runtime `Id` from a method such as `Handle::current().id()`. The `Id`'s documentation explains that it is intended to be an opaque handle. Therefore, we should not expose a way to construct one.
|
Closes #5545 |
github-actions
bot
added
R-loom-current-thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stabilizes the
runtime::id::Id.runtime::id::Iduniquely identifies a runtime relative to the parent process' other currently running runtimes.std::from::FromimplementationsThis commit removes the runtime
Id'sFromimplementations.Removing unnecessary public APIs makes stabilizing the
Idless risky. Instead, a crate privateId::newmethod has been introduced.This means that as of this commit, users can no longer safely construct an
Id.Instead, they must get a runtime
Idfrom a method such asHandle::current().id().It is assumed that there is no reason for a user to construct an
Idthemselves. If a use case is found then we can easily add public constructor functions later.