Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use [lints] to address unexpected_cfgs lint #7124

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 25, 2025

Motivation

Closes #6583

Solution

This uses [lints.rust.unexpected_cfgs.check-cfg] as suggested in #6583.

This also bumps nightly toolchain to the latest (nightly-2025-01-25) because the above config is not recognized in old nightly.

warning: /home/runner/work/tokio/tokio/Cargo.toml: unused manifest key: workspace.lints.rust.unexpected_cfgs.check-cfg

@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Jan 25, 2025
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 7f09959 into master Jan 25, 2025
88 checks passed
@Darksonn Darksonn deleted the taiki-e/check-cfg branch January 25, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use [lints.rust.unexpected_cfgs.check-cfg] instead of hacky check-cfg workaround
2 participants