Error handling, clippy #7032
Open
Error handling, clippy #7032
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that seek_pos is only reset if the seek operation completed successfully.
github-actions
bot
added
R-loom-sync
Darksonn
reviewed
Jan 8, 2025
| @@ -500,7 +500,7 @@ impl TimerEntry { | |||
| *self.inner.get() = Some(TimerShared::new(shard_id)); | |||
| } | |||
| } | |||
| return inner.as_ref().unwrap(); | |||
| inner.as_ref().unwrap() | |||
There was a problem hiding this comment.
The indentation here seems to be wrong.
Comment on lines
-235
to
+237
| *self.as_mut().project().seek_pos = None; | ||
| if res.is_ok() { | ||
| *self.as_mut().project().seek_pos = None; | ||
| } |
There was a problem hiding this comment.
Why is this being changed? Is there a use-case where this behaves incorrectly? Can you add that use-case as a test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Handling, several fix clippy warnings