Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-atomic targets by using portable-atomic #751

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tjoslin
Copy link

@tjoslin tjoslin commented Dec 22, 2024

squashed commits from upstream #467 by @taiki-e and rebased with updated deps and resolved conflicts

I'm not sure this should be merged as-is because the original author would lose credit but given the comments on #467 I figured this was a useful exercise to see what else would be necessary to add before a merge could occur.

squashed commits from upstream tokio-rs#467 and rebased with updated deps
@ia0
Copy link

ia0 commented Dec 23, 2024

the original author would lose credit

In the worst case, you can always add Co-authored-by: Taiki Endo <email redacted> at the end of the commit(s) that will end up merged (copying the email from the commits of #467).

@tjoslin
Copy link
Author

tjoslin commented Dec 23, 2024

the original author would lose credit

In the worst case, you can always add Co-authored-by: Taiki Endo <email redacted> at the end of the commit(s) that will end up merged (copying the email from the commits of #467).

Yeah, if they do not have bandwidth to continue their PR that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants