Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Buf::chunks_vectored for VecDeque<u8> #708

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented May 20, 2024

A tiny step closer at making #474 and #701 harder to encounter.

@paolobarbolini paolobarbolini force-pushed the vec-deque-chunks-vectored branch 2 times, most recently from ed4d78f to 52c6b7f Compare May 22, 2024 04:44
@paolobarbolini
Copy link
Contributor Author

I'm starting to think this will require something more creative to get VecDeque to become noncontinuous.

@paolobarbolini
Copy link
Contributor Author

paolobarbolini commented Nov 27, 2024

I'll rebase on top of #747 once it's merged, since there I found a reliable way of making a discontinuous VecDeque both on the old implementation (Rust 1.0 -> 1.66) and the new one (1.67 -> current) introduced by rust-lang/rust#102991

@paolobarbolini paolobarbolini force-pushed the vec-deque-chunks-vectored branch from 52c6b7f to 7de8c4e Compare January 9, 2025 16:17
@paolobarbolini paolobarbolini changed the title Implement chunks_vectored for VecDeque<u8> Implement Buf::chunks_vectored for VecDeque<u8> Jan 9, 2025
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 16cc574 into tokio-rs:master Jan 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants