-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix variable setting for various cases #3219
Conversation
🦋 Changeset detectedLatest commit: 1f7988b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Commit SHA:949b608b303c7eceb28200e1d928c58bade10eec Test coverage results 🧪
|
Commit SHA:949b608b303c7eceb28200e1d928c58bade10eec |
Tested with exporting as sets and exporting as themes. Both work as expected and you can change a reference to raw value and vice versa again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected!✨
Why does this PR exist?
Closes #3208
The prod version currently just checks for equality of old value vs new value, but forgets that alias references could exist which would always mean they're not equal - thus we're not updating the reference when the user goes from reference -> hard value. It worked before if we went from reference -> another reference (because another function is responsible for that)
What does this pull request do?
This PR modifies the early return to not return if we have an alias reference, and instead go and update.
Testing this change
Create variables of all types and export to Figma that are a hard value and the other a reference to another variable
Then update the variable that references to now be a hard value again.