Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Variables: once Variables are exported, you can't update a reference to raw value and vice versa #3208

Closed
rbosker opened this issue Nov 22, 2024 · 5 comments · Fixed by #3219
Assignees
Labels
bug Something isn't working Figma export - sets Figma export - themes Figma export Previously create and sync styles variables Figma variables needs-responder setting export - styles with variable references In the export to Figma options menu

Comments

@rbosker
Copy link
Collaborator

rbosker commented Nov 22, 2024

Describe the bug
once Variables are exported, you can't update a reference to raw value and vice versa

To Reproduce
Steps to reproduce the behavior:

  1. Create 2 color tokens: Token 1 having a raw hex value and Token 2 referencing Token 1
  2. Export these as Variables (Themes export)
  3. Change Token 2 to a raw HEX value and in Token 1 you reference Token 2 now
  4. Export your variables again.
  5. See that the Variable that first referenced another value stays as a referenced token and the color is not updated. The variable that was initially a raw value, updates the value, but isn't changing to a referenced token/variable.

Expected behavior
Expect that Token 1 updates to a referenced Variable in step 4. Expect Token 2 to update to a Hex value with the correct value.

Screenshots or Screencasts
https://github.com/user-attachments/assets/7c27dda7-dd21-40de-93d4-0b4b3e20795b

Note
This probably also applies for other token types.

@liamco
Copy link

liamco commented Nov 26, 2024

Not sure if this helps or muddies the waters but I just submitted a bug report where we're having a pretty similar issue; #3209

@DarioSoller
Copy link

DarioSoller commented Dec 6, 2024

We are also affected by that bug at the moment. FYI: For us right now it's with some inset spacing tokens/variables, as this issue does not seem to be limited to a certain token type.

@akshay-gupta7
Copy link
Contributor

We are also affected by that bug at the moment. FYI: For us at the moment it's with some inset spacing tokens/variables, as this issue does not seem to be limited to a certain token type.

@DarioSoller We have a fix for this in progress, which should be released soon.

@DarioSoller
Copy link

@akshay-gupta7 nice that sounds promising. Actually for us this decides, if we will ship another design token release before Xmas or not. Looking forward to it. Thx for the quick update!

@six7 six7 closed this as completed in #3219 Dec 9, 2024
@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Dec 9, 2024
@six7
Copy link
Collaborator

six7 commented Dec 9, 2024

✅ This has been released with 2.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Figma export - sets Figma export - themes Figma export Previously create and sync styles variables Figma variables needs-responder setting export - styles with variable references In the export to Figma options menu
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants