fix(snowflake): generate LIMIT when OFFSET exists #4575 #4581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes snowflake problem #4575
This PR allows the generation of snowflake queries when the
OFFSET
is present in the input dialect without aLIMIT
.Based on the snowflake's doc, an
OFFSET
must always match with aLIMIT
. Based on the discussion here, aLIMIT NULL
can be inserted into the query in order to be parsed correctly.Example:
Docs
Snowflake LIMIT