[1858 Switzerland] Avoid modifying 1858's train definitions #11411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao#11372 was caused by modifying 1858's train definitions without a making a deep copy. If a game of 1858 is loaded on the server after a game of 1858 Switzerland then it is was seeing the version of the definitions after these modifications, causing errors as 1858 does not have a method for handling the `blue_privates_available` event. Making a deep copy of the train definitions prevents this error. This commit also makes a deep copy of the phase definitions. No problems have been observed with this, but making the copy is safer. Fixes tobymao#11372.
|
Hurrah! You found the cause of the problem - well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Notes
Issue #11372 was caused by modifying 1858's train definitions without a making a deep copy. If a game of 1858 is loaded on the server after a game of 1858 Switzerland then it is was seeing the version of the definitions after these modifications, causing errors as 1858 does not have a method for handling the
blue_privates_availableevent.Making a deep copy of the train definitions prevents this error.
This commit also makes a deep copy of the phase definitions. No problems have been observed with this, but making the copy is safer.
Fixes #11372.
Before clicking "Create"
masterAdd thepinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake