Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18USA] Fix P16 description #11323

Closed

Conversation

philcampeau
Copy link
Collaborator

Fixes #11025

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Description for P16 wasn't clear about tile being used - fixed
Clarified description as well.

Screenshots

Any Assumptions / Hacks

@philcampeau philcampeau requested a review from crericha as a code owner November 7, 2024 15:17
@ollybh ollybh added the 18USA label Nov 10, 2024
'May be placed on any existing normal city. Three of the track segments are optional and can be placed ' \
'pointing toward water or other off map areas.',
desc: 'Regional Headquarters may be used to upgrade a green or brown non-metropolis city after phase 5 begins. '\
'The X23 tile (RHQ label) may be placed on any existing normal city. Two of the track segments are optional '\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tile has 3 optional connections that are contiguous.

Recommend removing (RHQ label). The tile number is enough and the description is already long.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that the private text says 3 of the segments are optional in the physical version, but there are no spaces on the board that would require more than 2 to be ignored. Should we still have it say 3?

I'll remove the (RHQ label) text.

'pointing toward water or other off map areas.',
desc: 'Regional Headquarters may be used to upgrade a green or brown non-metropolis city after phase 5 begins. '\
'The X23 tile may be placed on any existing normal city. Two of the track segments are optional '\
'and can be placed pointing toward water or other off map areas.',
Copy link
Collaborator

@crericha crericha Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the optional track segments from three to two? Here are the rules (All-aboard edition):

Comes with the gray Regional Headquarters tile. The may be used to upgrade a green or
brown non-metropolis city after Phase 5 begins.
Three of the track segments are optional and can be placed pointing toward water or other other
map areas.

@crericha
Copy link
Collaborator

This doesn't look correct and I haven't gotten a response, so I'm going to close for now. Feel to reopen with the fixes when you have time.

@crericha crericha closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[18USA] Add tile information to P16 - Regional Headquarters
3 participants