Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consolidated harness #703

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

feat: consolidated harness #703

wants to merge 1 commit into from

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Mar 3, 2025

This PR consolidates our integration tests and benchmarks into a single harness.

Opened as a draft as I still need to re-add memory profiling and bench plots. Also needs a little work on configuration

Highlights

  • Shared code for tests and benches.
  • Supports native and browser. This means that tests only have to be written once and they will be run in both environments.
  • Simplify writing and maintaining tests using providers for dependency injection. We no longer have to duplicate setup and tear down of IO everywhere.
  • No more sudo and virtual network interfaces. The harness uses our network utilities in tlsn-utils to configure bandwidth and latency for benchmarks. This lets us get rid of the docker dependency as well.
  • Should reduce build/CI times.
  • Clap CLI for configuration

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 709 lines in your changes missing coverage. Please review.

Project coverage is 56.13%. Comparing base (cb13169) to head (23788c2).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/harness/bin/main.rs 0.00% 104 Missing ⚠️
crates/harness/src/tests.rs 0.00% 92 Missing ⚠️
crates/harness/src/runner/browser.rs 0.00% 88 Missing ⚠️
crates/harness/src/runner/native.rs 0.00% 83 Missing ⚠️
crates/harness/src/bench/prover.rs 0.00% 80 Missing ⚠️
crates/harness/src/bench.rs 0.00% 64 Missing ⚠️
crates/harness/src/bench/verifier.rs 0.00% 59 Missing ⚠️
crates/harness/src/bench/io.rs 0.00% 39 Missing ⚠️
crates/harness/src/provider.rs 0.00% 33 Missing ⚠️
crates/harness/src/runner.rs 0.00% 30 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #703      +/-   ##
==========================================
- Coverage   57.80%   56.13%   -1.68%     
==========================================
  Files         177      188      +11     
  Lines       21332    21970     +638     
==========================================
  Hits        12332    12332              
- Misses       9000     9638     +638     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant