Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add style guide #411

Merged
merged 1 commit into from
Jan 17, 2024
Merged

docs: add style guide #411

merged 1 commit into from
Jan 17, 2024

Conversation

themighty1
Copy link
Member

This PR adds a minimal style guide.

yuroitaki
yuroitaki approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @heeckhau should we also update the content of this file if we're not using the CHANGELOG.md
image

heeckhau
heeckhau approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one remark

@heeckhau
Copy link
Member

heeckhau commented Jan 16, 2024 •
edited
Loading

Looks good! @heeckhau should we also update the content of this file if we're not using the CHANGELOG.md

@yuroitaki I would postpone this until we switch to effectively using the conventional commit tooling.

sinui0
sinui0 approved these changes Jan 16, 2024
View reviewed changes
@themighty1 themighty1 merged commit 43a05c2 into dev Jan 17, 2024
15 checks passed
@themighty1 themighty1 deleted the style_guide branch January 17, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heeckhau heeckhau heeckhau approved these changes

@th4s th4s th4s approved these changes

@yuroitaki yuroitaki yuroitaki approved these changes

@sinui0 sinui0 sinui0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@themighty1 @heeckhau @th4s @yuroitaki @sinui0