Add support for passing params to plugin #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtsukino
reviewed
Feb 28, 2025
| @@ -356,6 +361,7 @@ export type PluginConfig = { | |||
| requests: { method: string; url: string }[]; // List of requests that the plugin is allowed to make | |||
| notaryUrls?: string[]; // List of notary services that the plugin is allowed to use (optional) | |||
| proxyUrls?: string[]; // List of websocket proxies that the plugin is allowed to use (optional) | |||
| parameters?: Record<string, ParameterConfig>; | |||
There was a problem hiding this comment.
i think this should be a config for Step instead of top-level Plugin since it's more flexible to define in a step to collect params from input.
It can be done in a separate PR though. Could you refactor so that this PR only add the ability to include a parameter when invoke using Provider API?
There was a problem hiding this comment.
True, yeah params for each step makes sense.
Sure I will try refactor this weekend so that this PR only allows params via Provider API.
|
this is awesome @dylan1951 ! Thank you for your contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #149
Can pass params via
client.runPlugin("abc..", {characterId: 1234})or input with GUI.Specify params in plugin config.json
I was going to make an example plugin etc but ran out of time for now maybe this is useful.