Updated movement by polling to achieve smoother movement #29
Conversation
Movement is handled by polling to avoid the default delay that the browser/OS' use before repeating held-down keys.
… to die. Added basic AI to enemies - they chase players if within a 10 tile radius. Lastly, changed the enemy movement interval to 1sec from 4secs to make things more interesting :)
|
Wow, I think I'm going about this pull request thing the wrong way. The first pull request I did that you merged was the first one I've ever done. I didn't realize I could commit to this pull request and you'd see it :) So basically I was just hacking away not meaning for you to use it lol. Having said that, your recommended changes make 100% sense and I'll fix and commit shortly. I really need to read up on pull requests, branches, and the basics on shared code development. I mean, what if I add a feature that I like, but you don't necessarily see as a good addition to your code base? Lastly, are you going to continue coding this game? Should I continue doing pull requests? I will probably be hacking on it here and there. |
Re-factored the heart drawing code to cache the jQuery object.
|
OK, so I've made those changes. So like I said I'm just hacking because it's fun :) which means my code could be better! Downside of the way the hearts are handled: it's all client side, but I'm sure you noticed that. Not ideal. |
|
I'm new to pull requests too ;) I do plan on keeping this game alive. Some of my projects are abandoned, but this one is just too fun to give up on. I agree, the hearts should be server side. There will eventually need to be a huge rewrite where inventory, health, positions, terrain modification is all made server side. But for now, it's just a fun little game, let the hackers hack. |
Movement key polling, health, simple NPC AI
|
Some bugs came up from this pull request: I was wondering if you wanted to tackle them? |
This removes the delay imposed by the browser/OS when a user holds down a movement key. This works by polling and tracking the movement keys. Right now it's set to check every 100 milliseconds. Tested in Chrome and Firefox in Ubuntu. This also limits the speed of the character to the polling interval. This is pretty simple and perhaps not ideal, but should give you an idea :)