LSP: Use maximum obligation status instead of latest. #194
+84
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a proof step, we will take the maximum of statuses returned by different provers for each obligation and the minimum across the obligations. Taking the latest sometimes failed because of race conditions from the prover, e.g. first reporting true from TLAPM and later receiving false from SMT resulted in false status. Signed-off-by: Karolis Petrauskas <[email protected]>
…ient. Signed-off-by: Karolis Petrauskas <[email protected]>
Also deriving.show added for some types in LSP. Signed-off-by: Karolis Petrauskas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a proof step, we will take the maximum of statuses returned by different provers for each obligation and the minimum across the obligations. Taking the latest sometimes failed because of race conditions from the prover, e.g., first reporting true from TLAPM and later receiving false from SMT, which resulted in false status.
It should be merged after #193.