Fix race condition, and add pool support to store. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjni
force-pushed
the
wfh/_/parallel_tests
branch
from
f4a1f7e to
c9418ac
Compare
|
ty team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying langchain-ai/langgraph#2494. Replaces #20.
In that PR, a pool is created through arguments passed into the
from_conn_stringmethod of the store, but I've opted for the time being to leave that out and require pool creation first before passing it into the constructor of the store. This is what is needed currently for the checkpointer. I'm keeping it like this for now in case this difference upstream needs to be sorted out in the future.